Skip to content

Add incremental build cache support and parallel linking #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
js-9 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add incremental build cache support and parallel linking #300

js-9 wants to merge 3 commits into from
+48 −2

Conversation

@js-9
Copy link

@js-9 js-9 commented Dec 6, 2025 •
edited
Loading

Changes

  • write incremental build output to Library so it is cached together with the Library
  • enable parallel linking for il2cpp test runs

Successful Workflow Run Link

Checklist

  • Read the contribution guide and accept the code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Related documentation PR at game-ci/documentation#522

Summary by CodeRabbit

  • Chores
    • Updated Docker environment configuration for Windows systems with cache directory settings to ensure consistent behavior across deployments.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Cat Gif

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025 •
edited
Loading

Walkthrough

A single environment variable BEE_CACHE_DIRECTORY has been added to the Windows Docker run command in src/model/docker.ts. This variable points to a cache directory path and requires no functional logic changes.

Changes

Cohort / File(s) Summary
Docker Configuration
src/model/docker.ts		 Added --env BEE_CACHE_DIRECTORY=c:/github/workspace/Library/bee_cache to Windows Docker run command

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line environment variable addition to a Docker command
  • No control flow or logic changes
  • Straightforward parameter configuration

Poem

🐰 A cache path in the Docker night,
Whispered softly to the Windows light,
BEE_CACHE_DIRECTORY finds its way,
In /github/workspace, safe to stay! 🍯

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing the required 'Related Issues' and 'Related PRs' sections, and lacks a workflow run link. Add the missing 'Related Issues' section, add the source branch link to 'Related PRs', and provide a successful workflow run link from your own repository.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the PR objectives: it describes both main changes (incremental build cache support and parallel linking) that are implemented in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@js-9
Copy link
Author

js-9 commented Dec 6, 2025

@timcassell Would you mind giving it a spin and reporting? I don't run il2cpp tests myself..a link to a successful run would be appreciated.

@js-9 js-9 mentioned this pull request Dec 6, 2025
Open
6 tasks
coderabbitai[bot]
coderabbitai bot reviewed Dec 6, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/model/docker.ts (1)

140-140: Consider adding a comment explaining BEE_CACHE_DIRECTORY.

Adding an inline comment would help maintainers understand the purpose of this environment variable and its relationship to Unity's Bee build system and IL2CPP caching.

Apply this diff to add documentation:

                ${ImageEnvironmentFactory.getEnvVarString(parameters)} \
+                # Configure Unity Bee build cache for incremental IL2CPP builds
                --env BEE_CACHE_DIRECTORY=c:/github/workspace/Library/bee_cache \
                --env TEST_PLATFORMS="${testPlatforms}" \
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61fd9aa and 6e94677.

⛔ Files ignored due to path filters (1)
  • dist/test-standalone-scripts/Assets/Editor/UnityTestRunnerAction/PlayerBuildModifier.cs is excluded by !**/dist/**
📒 Files selected for processing (1)
  • src/model/docker.ts (1 hunks)

@js-9 js-9 mentioned this pull request Dec 6, 2025
Open
3 tasks
@timcassell
Copy link
Contributor

timcassell commented Dec 7, 2025

Failed run: https://github.com/timcassell/ProtoPromise/actions/runs/19996793002

@js-9
Copy link
Author

js-9 commented Dec 7, 2025

Failed run: https://github.com/timcassell/ProtoPromise/actions/runs/19996793002

Thanks!
I've forked your repo so now have a proper way of testing the changes. I'll post a comment if I manage to fix the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@js-9 @timcassell